-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
FIX: don't create 32 bit int type for int64 column (GH7433) #7634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: don't create 32 bit int type for int64 column (GH7433) #7634
Conversation
Tests are passing. @mangecoeur @danielballan OK with this? |
Looks good. |
Could someone test it with oracle? |
FIX: don't create 32 bit int type for int64 column (GH7433)
I see that there are on travis a lot of warnings after merging this. So the tests pass, but raise warnings like: I didn't see this warning, and after testing, I don't see it with sqlalchemy 0.9.6 and 0.8.3, but I do see it with 0.8.1 (the version used on travis for build 3). As the tests pass, I assume this is not a problem. But anybody an idea to prevent this warning is raised when users have an older version of sqlalchemy? |
so u want to put in place one/both of those newer versions on Travis? which ones should I replace? |
Well, already different version are used on different builds on travis. The older version 0.7.1 is used on py2.6, 0.8.1 is used on py2.7 and 0.9.1 is used on py3.3. So the older version of 0.7.1 should be kept to test compatibility with older sqlalchemy, the other ones could be updated to the latest sqlalchemy version. |
This issue was solved in 0.8.2 (https://bitbucket.org/zzzeek/sqlalchemy/issue/2764/make-sqlite-handle-bigint). So, or we live with the fact that users with older versions of sqlalchemy get this warning, or we can also try to 'fix' it ourselves with something like: https://review.openstack.org/#/c/23883/4/nova/db/sqlalchemy/__init__.py (from, a similar nova bug) |
I wouldn't worry about in that case; changing the 3.4 build to use 0.9.6 |
You can also change the 2.7 build to use 0.9.6, then the warning don't noise the travis test output (and the older 0.7.1 is still tested in 2.6) |
both done (Travis still building master though) |
Closes #7433
Replace the sqlalchemy
Integer
type withBigInteger
as the default integer type in pandas is int64.Probably we could be more specific in the type conversion (check for the exact integer type).